Add TIMEOUT in the list of allowed config paramaters, make sure no random memory is parted for potential options and fix output when the parameters name entered is invalid#43
Open
mochouinard wants to merge 1 commit intodeanproxy:masterfrom
Conversation
…ndom memory is parted for potential options and fix output when the parameters name entered is invalid
Author
|
The reason for this change, is because if my DNS server is not responding, EXIM4 take more than 10 second to timeout before answering on port 25. Even if Internet is down, I want my email to be queued by the local agent |
deanproxy
reviewed
Nov 13, 2017
| "VCARD" | ||
| "VCARD", | ||
| "TIMEOUT", | ||
| "" |
Owner
There was a problem hiding this comment.
Would it make sense to just kill the MAX_CONF_VARS macro all together and have conf_vars just be a pointer-array?
static char *conf_vars[] = {
"USE_TLS",
/* ... */,
"TIMEOUT",
NULL
}
| int i; | ||
|
|
||
| for (i = 0; i < MAX_CONF_VARS; i++) { | ||
| for (i = 0; strcasecmp("", conf_vars[i]) ; i++) { |
Owner
There was a problem hiding this comment.
Then here it would be a bit more simple and performant to just say:
for (i = 0; conf_vars[i]; i++) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TIMEOUT in the list of allowed config paramaters, make sure no random memory is parted for potential options and fix output when the parameters name entered is invalid.
Note that the timeout error output would still show (10) even if a different timeout is set.